feature(store): add get_metadata and set_metadata methods to stores#111
Closed
jhamman wants to merge 1 commit intod-v-b:v3_group_testsfrom
Closed
feature(store): add get_metadata and set_metadata methods to stores#111jhamman wants to merge 1 commit intod-v-b:v3_group_testsfrom
jhamman wants to merge 1 commit intod-v-b:v3_group_testsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pointing at @d-v-b's fork because I branched of
v3_group_tests. Once that PR goes in, I'll set the target to the zarr-python v3 branch.Description: This PR adds two new methods to the v3 Store API (
get_metadataandset_metadata). For most stores, this means that JSON serialization now happens in the Store. Crucially, this unlocks the ability for some stores to keep metadata in a container other than JSON (e.g. in a database that natively stores dictionaries).Xref: zarr-developers#1686 (comment)
TODO: