Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: d-Rickyy-b/certstream-server-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.6.0
Choose a base ref
...
head repository: d-Rickyy-b/certstream-server-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.7.0
Choose a head ref
  • 20 commits
  • 11 files changed
  • 2 contributors

Commits on May 30, 2024

  1. chore: update dependencies

    d-Rickyy-b committed May 30, 2024
    Configuration menu
    Copy the full SHA
    d74fcbc View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Ensure that Dockerfile_multistage builds and is runnable

    It appears that the `go build` command was pointing to the wrong directory - the build was failing as follows:
    ```
    ...
     => ERROR [builder 7/8] RUN go build -ldflags="-w -s" -o /go/bin/certstream-server-go /go/src/certstream-server-go/cmd
    ------
     > [builder 7/8] RUN go build -ldflags="-w -s" -o /go/bin/certstream-server-go /go/src/certstream-server-go/cmd:
    no Go files in /go/src/certstream-server-go/cmd
    ```
    
    After it was fixed, the configfile had 0750 permissions - it was owned by root:root, thus certstream-server-go was failing to start.
    ```
    config.go:49: Error while parsing yaml file: open /app/config.yaml: permission denied
    ```
    This commit resolves this issue too.
    alberts-s committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    0f4c946 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #38 from alberts-s/fix-docker

    Ensure that Dockerfile_multistage builds and is runnable
    d-Rickyy-b authored Jun 16, 2024
    Configuration menu
    Copy the full SHA
    10238cd View commit details
    Browse the repository at this point in the history
  3. chore: update codeql to v3

    d-Rickyy-b committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    122fc7b View commit details
    Browse the repository at this point in the history
  4. feat: support server initiated heartbeats

    Before this change the websocket server would not have any heartbeat mechanism,
     this meant that unless the client proactively implements heartbeats the server
     would close the connection. From what I have seen most non-browser clients do
     not implement heartbeats (e.g filebeat, websocat), thus for those clients the
     connection would have been closed in 65 seconds.
    
    The Websocket RFC does not set out a requirement which side should initiate
     heartbeats or that they are required. Most browsers have implemented heartbeats
     from client side, however it is not a must thus, in my opinion it is beneficial
     for the server to implement them, especially if the server closes connection if
     heartbeat is not received. As a consequence this changeset allows to support
     clients which aren't browsers.
    alberts-s committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    41bc270 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. feat: support compression

    This commit adds the ability to enable compression for websockets.
    The compression is disabled by default due to the fact that it is marked
    as experimental in gorilla/websocket and there have been issues with
    compression whenever Safari is enabled.
    This commit partially addresses #30.
    alberts-s committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9e6c5de View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. refactor: remove ping prints

    While this is great for debugging purposes, this rather spams the log with a large number of clients.
    d-Rickyy-b committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    487dbad View commit details
    Browse the repository at this point in the history
  2. refactor: don't ignore error return values

    I ignored them before, and even though it's unlikely for errors to occur here, It's better to handle them properly.
    d-Rickyy-b committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    f5ecce4 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #39 from alberts-s/implement-server-pings

    Add support for server heartbeats
    d-Rickyy-b authored Jul 14, 2024
    Configuration menu
    Copy the full SHA
    2b5971c View commit details
    Browse the repository at this point in the history
  4. refactor: remove nil check for CompressionEnabled

    I appreciate the comment as explanation, but using regular bools in the struct will lead to the default values being parsed. The default value for bools is "false". So there's no need to use a pointer in here.
    d-Rickyy-b committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    de96f18 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2457962 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #40 from alberts-s/add-compression

    Add support for Websocket compression
    d-Rickyy-b authored Jul 14, 2024
    Configuration menu
    Copy the full SHA
    6adc0e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. feat: start new ct-watchers as new ct logs become available

    fixes #42
    
    We also needed a way to properly prevent the entries of the metrics map from being reset to 0. That's why I added the Init() method to the LogMetrics. It only sets the value of the operator/url combination to 0 if it doesn't exist before.
    
    If it already exists, it will be left alone.
    d-Rickyy-b committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    cd4aaef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b234e22 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    78f9ec3 View commit details
    Browse the repository at this point in the history
  2. docs: update changelog

    d-Rickyy-b committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6c2b10b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    57161c7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9b6e77d View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Configuration menu
    Copy the full SHA
    5c055cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03d878e View commit details
    Browse the repository at this point in the history
Loading