-
Notifications
You must be signed in to change notification settings - Fork 36
Comparing changes
Open a pull request
base repository: d-Rickyy-b/certstream-server-go
base: v1.6.0
head repository: d-Rickyy-b/certstream-server-go
compare: v1.7.0
- 20 commits
- 11 files changed
- 2 contributors
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d74fcbc - Browse repository at this point
Copy the full SHA d74fcbcView commit details
Commits on Jun 16, 2024
-
Ensure that Dockerfile_multistage builds and is runnable
It appears that the `go build` command was pointing to the wrong directory - the build was failing as follows: ``` ... => ERROR [builder 7/8] RUN go build -ldflags="-w -s" -o /go/bin/certstream-server-go /go/src/certstream-server-go/cmd ------ > [builder 7/8] RUN go build -ldflags="-w -s" -o /go/bin/certstream-server-go /go/src/certstream-server-go/cmd: no Go files in /go/src/certstream-server-go/cmd ``` After it was fixed, the configfile had 0750 permissions - it was owned by root:root, thus certstream-server-go was failing to start. ``` config.go:49: Error while parsing yaml file: open /app/config.yaml: permission denied ``` This commit resolves this issue too.
Configuration menu - View commit details
-
Copy full SHA for 0f4c946 - Browse repository at this point
Copy the full SHA 0f4c946View commit details -
Merge pull request #38 from alberts-s/fix-docker
Ensure that Dockerfile_multistage builds and is runnable
Configuration menu - View commit details
-
Copy full SHA for 10238cd - Browse repository at this point
Copy the full SHA 10238cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 122fc7b - Browse repository at this point
Copy the full SHA 122fc7bView commit details -
feat: support server initiated heartbeats
Before this change the websocket server would not have any heartbeat mechanism, this meant that unless the client proactively implements heartbeats the server would close the connection. From what I have seen most non-browser clients do not implement heartbeats (e.g filebeat, websocat), thus for those clients the connection would have been closed in 65 seconds. The Websocket RFC does not set out a requirement which side should initiate heartbeats or that they are required. Most browsers have implemented heartbeats from client side, however it is not a must thus, in my opinion it is beneficial for the server to implement them, especially if the server closes connection if heartbeat is not received. As a consequence this changeset allows to support clients which aren't browsers.
Configuration menu - View commit details
-
Copy full SHA for 41bc270 - Browse repository at this point
Copy the full SHA 41bc270View commit details
Commits on Jun 17, 2024
-
This commit adds the ability to enable compression for websockets. The compression is disabled by default due to the fact that it is marked as experimental in gorilla/websocket and there have been issues with compression whenever Safari is enabled. This commit partially addresses #30.
Configuration menu - View commit details
-
Copy full SHA for 9e6c5de - Browse repository at this point
Copy the full SHA 9e6c5deView commit details
Commits on Jul 14, 2024
-
While this is great for debugging purposes, this rather spams the log with a large number of clients.
Configuration menu - View commit details
-
Copy full SHA for 487dbad - Browse repository at this point
Copy the full SHA 487dbadView commit details -
refactor: don't ignore error return values
I ignored them before, and even though it's unlikely for errors to occur here, It's better to handle them properly.
Configuration menu - View commit details
-
Copy full SHA for f5ecce4 - Browse repository at this point
Copy the full SHA f5ecce4View commit details -
Merge pull request #39 from alberts-s/implement-server-pings
Add support for server heartbeats
Configuration menu - View commit details
-
Copy full SHA for 2b5971c - Browse repository at this point
Copy the full SHA 2b5971cView commit details -
refactor: remove nil check for CompressionEnabled
I appreciate the comment as explanation, but using regular bools in the struct will lead to the default values being parsed. The default value for bools is "false". So there's no need to use a pointer in here.
Configuration menu - View commit details
-
Copy full SHA for de96f18 - Browse repository at this point
Copy the full SHA de96f18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2457962 - Browse repository at this point
Copy the full SHA 2457962View commit details -
Merge pull request #40 from alberts-s/add-compression
Add support for Websocket compression
Configuration menu - View commit details
-
Copy full SHA for 6adc0e5 - Browse repository at this point
Copy the full SHA 6adc0e5View commit details
Commits on Aug 7, 2024
-
feat: start new ct-watchers as new ct logs become available
fixes #42 We also needed a way to properly prevent the entries of the metrics map from being reset to 0. That's why I added the Init() method to the LogMetrics. It only sets the value of the operator/url combination to 0 if it doesn't exist before. If it already exists, it will be left alone.
Configuration menu - View commit details
-
Copy full SHA for cd4aaef - Browse repository at this point
Copy the full SHA cd4aaefView commit details -
Configuration menu - View commit details
-
Copy full SHA for b234e22 - Browse repository at this point
Copy the full SHA b234e22View commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 78f9ec3 - Browse repository at this point
Copy the full SHA 78f9ec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c2b10b - Browse repository at this point
Copy the full SHA 6c2b10bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57161c7 - Browse repository at this point
Copy the full SHA 57161c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b6e77d - Browse repository at this point
Copy the full SHA 9b6e77dView commit details
Commits on Aug 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5c055cc - Browse repository at this point
Copy the full SHA 5c055ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03d878e - Browse repository at this point
Copy the full SHA 03d878eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.6.0...v1.7.0