Add embedsignature for special methods#6764
Conversation
3de2ab6 to
cf8d263
Compare
|
Indeed, it looks like the bug is not introduced by this pull request. With latest master, without this pull request:
→ What should I do (it shouldn't be in the scope of this pull request to also fix that issue?) |
|
I think this is something where we can live with the Limited API not working quite right (especially since it seems to be pre-existing). If you do (or something similar) then you can see that's it's activated and disable the individual test. |
|
Any idea why |
|
Not sure about the first but the test runner automatically copies all files called "currenttestname*.*" into the test execution directory (every test has its own directory) but not apparently unrelated files. |
|
Maybe that's the cause. What is your recommendation here, copy paste the function to every file as before? (the alternative is to modify |
|
… maybe the cause is I forget to I guess I can run CI on my fork too, then no need for approval for debugging on my side. Let's see. https://github.com/user202729/cython/actions/runs/14247014745 Edit: yes looks like they all passes. |
|
Thanks |
Partial fix for #1577 .
Will work when the method already has a docstring, but otherwise no guarantee. The reason is explained in the code.
Unfortunately I don't know how to fix it properly yet.
Looks like the test failure with limited API is existing bug rather than caused by this one? It is showing the superclass's docstring.