Apply #3782 to all MSVC version#4357
Apply #3782 to all MSVC version#4357scoder merged 1 commit intocython:masterfrom maxbachmann:patch-6
Conversation
If I understand right it can sometimes be required if you have an enum class and something else with the same name then using the type specifier gets makes sure that you get the enum. It's a rare corner case but it seems worth keeping. Therefore, I'd rather have a compiler version check if possible. It's a little tricky to pin down exactly when it was fixed but the internet suggests it was fixed in Visual Studio 2017. Therefore a version check of I think it's right to base this on MSVC version rather than Python version (we started with Python version because 3.4 requires quite an old compiler) |
|
Thanks |
This applies the fix from #3782 to all Python version, since it is not specific to Python3.4.
I assume it only occurs on some versions of MSVC. In my case the build:
@scoder @da-woods is there any reason why we should not completely drop the type specifier for enum classes?