Fixed "test_*_path_exists" + CompilerDirectivesNode#3619
Merged
scoder merged 2 commits intocython:masterfrom May 19, 2020
Merged
Fixed "test_*_path_exists" + CompilerDirectivesNode#3619scoder merged 2 commits intocython:masterfrom
scoder merged 2 commits intocython:masterfrom
Conversation
When test_assert_path_exists or test_fail_if_path_exists was used on a function containing a CompilerDirectivesNode it was inherited by that CompilerDirectivesNode. Therefore you got misleading test failures if the path was in the function but not within that CompilerDirectivesNode.
Contributor
|
Interesting catch. Thanks. These really shouldn't get inherited anywhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
test_assert_path_existsortest_fail_if_path_existswas used on a function containing aCompilerDirectivesNodeit was inherited by thatCompilerDirectivesNode. Therefore you got misleading test failures if the path was in the function but not within thatCompilerDirectivesNode.Specifically this was causing a lot of failures in #3617 because I'd generated a
CompilerDirectivesNodearound anIndexNode. However, submitting separately since it's a general fix to the test-suite.