Skip to content

Fix the cdiv() and cmod() definitions in Shadow.py#3429

Merged
scoder merged 1 commit intocython:masterfrom
ZackerySpytz:cdiv-cmod
Mar 16, 2020
Merged

Fix the cdiv() and cmod() definitions in Shadow.py#3429
scoder merged 1 commit intocython:masterfrom
ZackerySpytz:cdiv-cmod

Conversation

@ZackerySpytz
Copy link
Contributor

Closes #2643.

@McSinyx
Copy link
Contributor

McSinyx commented Mar 14, 2020

Is backward compatibility considered? I mean if someone relies on the old C-like division behavior?

Edit: nvm adding it to the changelog might be good enough.

@scoder scoder added this to the 3.0 milestone Mar 16, 2020
@scoder
Copy link
Contributor

scoder commented Mar 16, 2020

Thanks

@scoder scoder merged commit c5f2231 into cython:master Mar 16, 2020
@scoder
Copy link
Contributor

scoder commented Mar 16, 2020

@McSinyx, users would normally rely on the compiled behaviour rather than the implementation in Shadow.py here, because that's what they aim for in the first place. Any discrepancy between the two should just be fixed in Shadow.py and follow the compiled behaviour (well, assuming that is correct, but you get the idea).

@McSinyx
Copy link
Contributor

McSinyx commented Mar 16, 2020

@scoder: Thank you for the insight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cdiv and cmod incorrect?

3 participants