Fix interspersed positional arguments in cythonize.py#2988
Merged
scoder merged 5 commits intocython:masterfrom Jun 11, 2019
Merged
Fix interspersed positional arguments in cythonize.py#2988scoder merged 5 commits intocython:masterfrom
scoder merged 5 commits intocython:masterfrom
Conversation
8891fe3 to
6fb2d5b
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fix for a regression in #2952: in optparse interspersed arguments are on per default, but not in argparse (I was not able to parse this information from https://docs.python.org/3.7/library/argparse.html#upgrading-optparse-code), thus the following
cythonize.py file1 -a file2
works with optparse but not argparse.
As the native-argparse support for interspersed/intermixed arguments is only available since Python3.7 (https://bugs.python.org/issue14191) we need to emulate it.