Fix parallel option test in TestCythonizeArgsParser#2982
Merged
scoder merged 1 commit intocython:masterfrom Jun 7, 2019
Merged
Fix parallel option test in TestCythonizeArgsParser#2982scoder merged 1 commit intocython:masterfrom
scoder merged 1 commit intocython:masterfrom
Conversation
Contributor
|
Nice one, thanks. Shows how common dual-core CPUs still are these days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that most of the tests in TestCythonizeArgsParser were failing for me because options.parallel was hard coded to test against a default value of 3 when it is actually set to floor(CPU cores * 1.5). Fixed by importing the actual default and checking against that instead.