[0.29.x] Unicode tests fix for Py3.8#2958
Merged
Conversation
Contributor
|
Thanks, but these are tests copied from CPython, and the parts that I disabled mostly test CPython. The only exception is the I would like to keep the other tests close to the way they are written in CPython to simplify later updates. |
Contributor
|
What CPython version? |
Contributor
|
Not sure what exactly you're asking, but I recently updated the test file from the latest CPython master while I was trying to fix the test, after noticing that it started failing in 3.8. |
Contributor
|
That's all i needed to know. |
Author
|
@scoder So in order to get this PR merged I should disable the other tests again and keep only the FI/Finnish conditional. Can you please confirm? |
Contributor
|
Yes, that would be ok as a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enables disabled unicode tests with Py3.8 on the 0.29.x branch.