Clean weakrefs before calling user's dealloc#2930
Merged
scoder merged 1 commit intocython:masterfrom Apr 27, 2019
Merged
Conversation
We must clean the weakreferences before calling the user's __dealloc__ because if the __dealloc__ releases the GIL, a weakref can be dereferenced accessing the object in an inconsistent state or resurrecting it.
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must clean the weakreferences before calling the user's dealloc
because if the dealloc releases the GIL, a weakref can be
dereferenced accessing the object in an inconsistent state or
resurrecting it.
Closes #2929