Skip to content

provide support for the complex library#2891

Merged
robertwb merged 7 commits intocython:masterfrom
kif:c_complex_support
Jan 23, 2020
Merged

provide support for the complex library#2891
robertwb merged 7 commits intocython:masterfrom
kif:c_complex_support

Conversation

@kif
Copy link
Contributor

@kif kif commented Mar 9, 2019

available since C99... may be valid only after Python2 is dropped on
Windows.

available since C99... may be valid only after Python2 is dropped on
Windows.
@scoder scoder added this to the 3.0 milestone Mar 30, 2019
@scoder
Copy link
Contributor

scoder commented Mar 30, 2019

Please add a little test anyway. You can add it to the windows_bugs.txt file to exclude it in MSVC for now (preferably with a comment why it's excluded).

@scoder
Copy link
Contributor

scoder commented May 14, 2019

Ping! :)
A test would be helpful to get this merged.

@kif
Copy link
Contributor Author

kif commented May 15, 2019 via email

@kif
Copy link
Contributor Author

kif commented May 15, 2019

There is test that works for me ... not sure it works everywhere. let's wait for Travis' point of view

@kif
Copy link
Contributor Author

kif commented May 17, 2019

Just a question: How do you prevent the test to use the C++ backend ?

@scoder
Copy link
Contributor

scoder commented Jun 13, 2019

Sorry for the silence. There is a tag no-cpp for this (had to look it up myself, found it in runtests.py).

@leofang
Copy link

leofang commented Nov 20, 2019

Can this PR be merged? Having access to complex is helpful to scientific computing!

@kif
Copy link
Contributor Author

kif commented Nov 20, 2019

That was my original idea ...

@robertwb
Copy link
Contributor

This looks fine to me--doesn't change the default behavior and lets the user cimport rather than declare all of these methods, and the test looks fine as well. Thanks.

@robertwb robertwb merged commit 67b7719 into cython:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants