Merged
Conversation
|
This was referenced Aug 26, 2023
|
going to hold off on merging this until post Cy13 feedback dies down a bit. Don't want to introduce new possible vectors for problems that might mask Test Replay issues. |
Author
That is a very understandable tactic, given that:
add the following to "resolutions": {
"qs": "6.10.4"
} |
nagash77
approved these changes
Sep 5, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
|
@MikeMcC399 yeah I am seeing the same thing. Rerunning that build |
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist:
npm testlocally and all tests are passing.PR Description
~6.10.3to using a fixed version6.10.4according to one option in the recommendation fromqs@6.10.5:qsto6.10.4.Notes
The PR does not change the version of
qschosen when installing@cypress/requestwith npm or pnpm.The PR forces the choice of
qsversion made by Yarn so that it corresponds to the version choice made by npm and pnpm, which already resolve~6.10.3to the selection6.10.4. This avoids that Yarn chooses the deprecated6.10.5version.npm-pick-manifest mentions the algorithm whereby npm "Prefers non-deprecated versions to deprecated versions".