Skip to content

docs: update submission instructions in DEVELOPMENT.md#853

Merged
emilyrohrbough merged 4 commits into
cypress-io:masterfrom
MikeMcC399:docs/development
Apr 5, 2023
Merged

docs: update submission instructions in DEVELOPMENT.md#853
emilyrohrbough merged 4 commits into
cypress-io:masterfrom
MikeMcC399:docs/development

Conversation

@MikeMcC399

Copy link
Copy Markdown
Collaborator

This PR resolves #742.

It delivers an updated DEVELOPMENT.md document which takes account of changes in automated processing of action builds and checking through the Husky pre-commit hook and through github/workflows/check-dist.yml.

It makes it clearer about the necessary technical steps that Contributors to the repository should take.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 27, 2023 11:25
@AtofStryker AtofStryker self-requested a review March 28, 2023 17:52
@MikeMcC399 MikeMcC399 marked this pull request as draft March 28, 2023 22:03
@MikeMcC399

This comment was marked as resolved.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 29, 2023 12:44
Comment thread DEVELOPMENT.md
Comment thread DEVELOPMENT.md Outdated
Comment thread DEVELOPMENT.md Outdated
Comment thread DEVELOPMENT.md Outdated
@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

@AtofStryker

Many thanks for your review! I have taken account of your feedback and made changes in 3f0c293.

@MikeMcC399

This comment was marked as resolved.

@AtofStryker AtofStryker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end @MikeMcC399! @emilyrohrbough are you able to take a look as well?

Comment thread DEVELOPMENT.md
Comment thread DEVELOPMENT.md
Comment thread DEVELOPMENT.md
Comment thread DEVELOPMENT.md
Comment thread DEVELOPMENT.md Outdated
Comment thread DEVELOPMENT.md Outdated
Comment thread DEVELOPMENT.md Outdated
Comment thread DEVELOPMENT.md Outdated
Comment thread DEVELOPMENT.md Outdated
MikeMcC399 and others added 2 commits April 5, 2023 11:39
Co-Authored-By: Bill Glesias <bglesias@gmail.com>
@MikeMcC399 MikeMcC399 marked this pull request as draft April 5, 2023 09:53
@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 5, 2023 17:42
@MikeMcC399

This comment was marked as resolved.

Comment thread DEVELOPMENT.md Outdated
@CLAassistant

CLAassistant commented Apr 5, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

github-actions Bot commented May 1, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 5.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 added the documentation Improvements or additions to documentation label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incomplete build instructions in DEVELOPMENT.md

5 participants