Remove release dependency on markdown link check#762
Closed
MikeMcC399 wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
This is in draft state until I complete testing on it. Runs 4053044057 shows it running successfully as an independent job.
It includes the commit flag |
Collaborator
Author
|
If there is a markdown error then the workflow shows as having failed although the release job was successful. This is expected, however I think it makes more sense to separate out the check markdown into a new workflow which only checks the markdown, so I will close this PR and resubmit. This will make the results of the checks clearer and if there is a markdown error a PR can still be manually merged if this is justified. |
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #717 "Bad external links may block release".
In .github/workflows/main.yml
npm run check:markdownis removed from thebuild-and-testjob and placed it inside a new independent jobcheck-markdown-linksinside the same workflow.Verification
Error case
In a copy of the cypress-io/github-action/ repo:
npm run check:markdownand verify the test failsNon-error case
As above except with no markdown link error present.
Production case
Monitor production when a commit with
fix:,feat:orperf:in the title is merged into themasterbranch and check that a release takes place correctly.