Update CLI for the recent components creation & configuration split #385
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the CLI to support the recent split of component creation and configuration into separate operations. The main change introduces a combined PUT API endpoint that handles both creation and configuration for better CLI integration, while also making breaking changes to the component update command requiring stack-ref for non-existing components.
- Replaces separate create/configure operations with a combined
CreateAndConfigureComponentAPI - Updates component update logic to require stack-ref when component doesn't exist
- Reorganizes import statements and removes deprecated stack configuration commands
Reviewed Changes
Copilot reviewed 79 out of 80 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/testcfg/config.go | Updates test configuration to use new combined component creation API |
| cmd/cycloid/components/update.go | Adds stack-ref validation and uses combined create/configure endpoint |
| cmd/cycloid/components/create.go | Renames to CreateAndConfigureComponent and updates API calls |
| cmd/cycloid/middleware/organization_components.go | Implements new CreateAndConfigureComponent method and adds stack config retrieval |
| client/models/*.go | Adds new model definitions for combined component operations |
| cmd/cycloid/stacks/*.go | Removes deprecated stack config commands and updates use case handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b7f3f4a to
3dbdc44
Compare
There was a problem hiding this comment.
Please if possible, make the client update a separate PR.
There was a problem hiding this comment.
@kerak19
Also, you didn't added the version on the version file at the root of this folder
There was a problem hiding this comment.
Here's the client update: #387
I'll rebase this PR on top of it
There was a problem hiding this comment.
@kerak19
Also, you didn't added the version on the version file at the root of this folder
a0566b4 to
e23d714
Compare
It's |
9f8c997 to
9b527a1
Compare
Component creation & configuration was split into 2 parts on the API, but we also added a PUT that combines these two into one call. Updated the code to reflect these changes. Breaking: components update command will now fail if stack-ref isn't provided for non-existing component. It's a step forward to combine the create & update commands into one, so stack-ref is necessary in case the component doesn't exist and needs to be created. If it exists, it's updated otherwise
548bf3e to
dff5245
Compare
The component creation & configuration were split into two. As a remedy we provided separate PUT API endpoint that combines creation & configuration for the simpler CLI integration.
Breaking: components update command will now fail if stack-ref isn't provided for non-existing component. It's a step forward to combine the create & update commands into one, so stack-ref is necessary in case the component doesn't exist and needs to be created. If it exists, it's updated otherwise