Side Drawer by shresthabijay · Pull Request #221 · cybersemics/em

shresthabijay · 2019-12-18T21:15:50Z

Fixes #180

shresthabijay · 2019-12-19T17:31:13Z

added hamburger menu for both mobile and desktop view and added .npmrc file for setting up bit registry.

raineorshine · 2019-12-24T13:50:44Z

I recommend rebasing on dev to avoid additional merge conflict headaches.

shresthabijay · 2019-12-25T16:02:31Z

I recommend rebasing on dev to avoid additional merge conflict headaches.

Will do that

raineorshine

I'm very happy with what I see! The functionality is nearly perfect, and you accounted for the many, spread out changes needed to sync with state, local, and remote.

The suggestions are a combination of code quality recommendations, small bugs, and the use of mutations in existingThoughtChange.

Please run the linter manually (npm run lint) as the automated check is not failing properly.

The only other bug not listed here is the neglect of existingThoughtMove. When a thought is moved (either through drag-and-drop or the keyboard command Ctrl + Shift + Up/Down), it breaks recently edited functionality. The links should be updated as with edit.

src/App.css

src/components/Sidebar.js

src/util/sortByLastUpdated.js

src/util/sync.js

src/reducers/existingThoughtDelete.js

src/util/isDescendant.js

src/util/syncRemote.js

shresthabijay · 2019-12-26T17:27:16Z

I'm very happy with what I see! The functionality is nearly perfect, and you accounted for the many, spread out changes needed to sync with state, local, and remote.

The suggestions are a combination of code quality recommendations, small bugs, and the use of mutations in existingThoughtChange.

Please run the linter manually (npm run lint) as the automated check is not failing properly.

The only other bug not listed here is the neglect of existingThoughtMove. When a thought is moved (either through drag-and-drop or the keyboard command Ctrl + Shift + Up/Down), it breaks recently edited functionality. The links should be updated as with edit.

shresthabijay · 2019-12-26T17:29:06Z

I'm very happy with what I see! The functionality is nearly perfect, and you accounted for the many, spread out changes needed to sync with state, local, and remote.

The suggestions are a combination of code quality recommendations, small bugs, and the use of mutations in existingThoughtChange.

Please run the linter manually (npm run lint) as the automated check is not failing properly.

The only other bug not listed here is the neglect of existingThoughtMove. When a thought is moved (either through drag-and-drop or the keyboard command Ctrl + Shift + Up/Down), it breaks recently edited functionality. The links should be updated as with edit.

onExistingThoughtMove should the lastUpdated timestamp for that thought should be updated as well?

raineorshine

Thanks!

A small change needs to be made to ensure this works when editing thoughts in the Context View (Ctrl + Shift + S). When in the context view, the path needs to be linearized into a simple context. pathToContext assumes the given path has already been simplified and doesn't handle this unfortunately.

e.g. Given the following structure:

A
- x (cursor)
  - 1
B
- x
  - 2

If the cursor is at A • ~x (where ~ indicates the Context View is activated), then the user can navigate to A • ~x • B and B's child A • ~x • B • 2:

A
- ~x
  - B
    - 2 (cursor)

In this case, the cursor is A • ~x • B • 2, but the recently edited thought should be B • 2.

This should be as simple as using thoughtsNew instead of cursorNew in existingThoughtChange etc.

Let me know if that doesn't make sense! Thanks!

src/components/AppComponent.js

src/components/HamburgerMenu.js

src/components/Sidebar.js

src/reducers/existingThoughtChange.js

src/reducers/existingThoughtDelete.js

src/reducers/existingThoughtMove.js

src/util/syncRemote.js

package.json

shresthabijay · 2019-12-27T08:08:27Z

Thanks!

A small change needs to be made to ensure this works when editing thoughts in the Context View (Ctrl + Shift + S). When in the context view, the path needs to be linearized into a simple context. pathToContext assumes the given path has already been simplified and doesn't handle this unfortunately.

e.g. Given the following structure:

A

x (cursor)

1

B

x

2

If the cursor is at A • ~x (where ~ indicates the Context View is activated), then the user can navigate to A • ~x • B and B's child A • ~x • B • 2:

A

~x

B

2 (cursor)

In this case, the cursor is A • ~x • B • 2, but the recently edited thought should be B • 2.

This should be as simple as using thoughtsNew instead of cursorNew in existingThoughtChange etc.

Let me know if that doesn't make sense! Thanks!

thoughtsNew is a context while cursorNew is path. So we need to convert the thoughtsNew to a path. Is there any utility function that can do that in the current codebase?

raineorshine · 2019-12-27T15:56:50Z

thoughtsNew is a context while cursorNew is path. So we need to convert the thoughtsNew to a path. Is there any utility function that can do that in the current codebase?

rankThoughtsFirstMatch

src/components/Sidebar.js

src/reducers/existingThoughtMove.js

src/components/Sidebar.js

src/App.css

src/components/Breadcrumbs.js

src/components/Link.js

src/components/Breadcrumbs.js

raineorshine · 2019-12-31T15:59:41Z

src/components/Sidebar.js

+  const toggleEllipsis = () => {
+    setEllipsize(!ellipsize)
+  }


Can we make this internal to the Breadcrumbs component? I think it makes more sense there than in the Sidebar, which shouldn't be concerned with ellipses.

Yes it makes total sense.

…tall script for adding bit registry

@bit

…c with @bit:registry

…entlyEdited, updated all the descentdant context in the array when a thought is changed

… updated. made small changes to sidedrawer

…ed recently edit limit constant and added lodash.clonedeep

…gThoughtMove remains

…tating functions and fixed eslint errors

…ly edited thoughts tab

…dcrumbs component instead of Sidebar.)

shresthabijay marked this pull request as ready for review December 19, 2019 17:03

raineorshine changed the title ~~integrated very basic material ui drawer for mobile view~~ Side Drawer Dec 19, 2019

raineorshine force-pushed the dev branch from 47b45b5 to 90a9c3c Compare December 21, 2019 00:01

shresthabijay force-pushed the sidebar-integration branch from 42a8a0a to d480554 Compare December 25, 2019 19:17

raineorshine requested changes Dec 25, 2019

View reviewed changes

raineorshine force-pushed the dev branch from 2ea2284 to 520b39c Compare December 25, 2019 21:50

shresthabijay closed this Dec 26, 2019

shresthabijay reopened this Dec 26, 2019

shresthabijay force-pushed the sidebar-integration branch from d480554 to 5fef9e9 Compare December 26, 2019 19:46

raineorshine requested changes Dec 26, 2019

View reviewed changes

shresthabijay force-pushed the sidebar-integration branch from 22ccd1e to 33e7bd1 Compare December 27, 2019 07:31

shresthabijay force-pushed the sidebar-integration branch from 33e7bd1 to 74d776c Compare December 29, 2019 05:42

raineorshine requested changes Dec 29, 2019

View reviewed changes

src/components/Sidebar.js Outdated Show resolved Hide resolved

src/reducers/existingThoughtMove.js Outdated Show resolved Hide resolved

src/components/Sidebar.js Outdated Show resolved Hide resolved

src/components/Sidebar.js Outdated Show resolved Hide resolved

raineorshine requested changes Dec 31, 2019

View reviewed changes

Bijay Shrestha and others added 9 commits January 1, 2020 00:32

integrated very basic material ui drawer for mobile view

cea03bf

created toggleSibar reducer, added hamburger menu and included preins…

610a129

…tall script for adding bit registry

setting bit registry in preinstall script didn't work so created npmr…

c748e43

…c with @bit:registry

local and state sync of recentlyEdited, array is used for storing rec…

1afa5cb

…entlyEdited, updated all the descentdant context in the array when a thought is changed

changed from context to path for recently edited data. sorted by last…

4d11911

… updated. made small changes to sidedrawer

sync of recently edited thoughts on thought delete

1f5fc08

remote sync added, commented codes for thought change and delete, add…

7352d31

…ed recently edit limit constant and added lodash.clonedeep

rebased to dev and made some changes

91058b6

almost all issues resolved, udpate of recently edited data on existin…

4b12c0a

…gThoughtMove remains

shresthabijay added 10 commits January 1, 2020 00:33

update recentlyEdited data onExistingThoughtMove complete, removed mu…

4d73b4c

…tating functions and fixed eslint errors

css changes

d25b0ba

issues resloved , context problem left to solve

1e0e98b

rebased to dev

189604e

context view onExistingThoughtChange updated

1c74cc5

context view existingThoughtChange and delte update

915f01d

reabsed to dev and made some changes

8e973d0

fixed eslint errors and updated redux

0908d5d

ellipsis logic added to breadcrumbs and is rendered inside the recent…

259e689

…ly edited thoughts tab

resolved all the issues and hook state of ellipsize moved to the Brea…

892b9a2

…dcrumbs component instead of Sidebar.)

shresthabijay force-pushed the sidebar-integration branch from 27e76af to 892b9a2 Compare December 31, 2019 18:53

Merge branch 'dev' into sidebar-integration

0e7e901

raineorshine merged commit 52ebf0d into cybersemics:dev Dec 31, 2019

Conversation

shresthabijay commented Dec 18, 2019 • edited by raineorshine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shresthabijay commented Dec 19, 2019

Uh oh!

raineorshine commented Dec 24, 2019

Uh oh!

shresthabijay commented Dec 25, 2019

Uh oh!

raineorshine left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shresthabijay commented Dec 26, 2019

Uh oh!

shresthabijay commented Dec 26, 2019

Uh oh!

raineorshine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shresthabijay commented Dec 27, 2019

Uh oh!

raineorshine commented Dec 27, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

raineorshine Dec 31, 2019

Choose a reason for hiding this comment

Uh oh!

shresthabijay Dec 31, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shresthabijay commented Dec 18, 2019 •

edited by raineorshine

Loading

raineorshine left a comment •

edited

Loading