stop propagation for MouseEvent of Editable#1135
Merged
raineorshine merged 1 commit intodevfrom May 12, 2021
Merged
Conversation
raineorshine
approved these changes
May 12, 2021
Contributor
|
Works great! I tested it very thoroughly on iOS with all of the #1128 subissues and could not reproduce any of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for the case: #1029 (comment)
Reason
I had added e.stopPropagation() in onTap to block the triggering onMouseDown event of Content element(event bubbling). But this also blocks the calling onTouchEnd event in TouchMonitor.tsx
Solution:
In onTap function we need to stop propagation if event type is a MouseEvents. As I said before, for touch events e.stopPropagation() won't block the event bubbling for mouse events. It only blocks the event bubbling for touch events. So, it blocks the calling onTouchEnd event of TouchMonitor.
There will be no problem for TouchEvents because this is an edge case scenario, and in this case the onTap gets onMouseDown event not onTouchEnd event, because touch is not ended on Editable element, touch is ended on Content. You can see the case at #1128 (comment)