Skip to content

Conversation

@amirnachman
Copy link
Contributor

Desired Outcome

  • Added JSON export option.
  • Removed locked sub window focus, now you can open new sub window and be able to go to the main window.
  • Added windows focus when trying to open new sub window, so i.e if you open search window and press again to open, it will set the focus on the search.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

- Added JSON export option.
- Removed locked sub window focus, now you can open new sub window and be able to go to the main window.
- Added windows focus when trying to open new sub window, so i.e if you open search window and press again to open, it will set the focus on the search.
@amirnachman amirnachman changed the title Added CSV Added CSV\JSON import option and sub windows focus modification Aug 9, 2023
@g3rzi g3rzi merged commit eeab198 into cyberark:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants