Skip to content

Create ExecutionContext and show example with ActionPluginProxy#173

Open
cwperks wants to merge 5 commits intomainfrom
plugin-aware-action-plugin
Open

Create ExecutionContext and show example with ActionPluginProxy#173
cwperks wants to merge 5 commits intomainfrom
plugin-aware-action-plugin

Conversation

@cwperks
Copy link
Copy Markdown
Owner

@cwperks cwperks commented May 31, 2024

Description

This PR creates a new part of the ThreadContext called ExecutionContext that is intended to hold an identifier to the plugin that is currently executing code. Ideally, this class is not exposed to plugins and is populated before the core defers execution to a plugin when an extension point is called directly and is cleared upon returning back to the core.

This PR does not consider cases where a plugin spins off a new thread or calls code in another plugin (is that possible?).

Related Issues

Related to: opensearch-project/security#4208

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks added 4 commits May 30, 2024 16:33
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant