fixes: correct pcnum selection in glmsingle.py and session loop data handling in calcbadness.py#189
Merged
jacob-prince merged 1 commit intomainfrom Aug 28, 2025
Merged
fixes: correct pcnum selection in glmsingle.py and session loop data handling in calcbadness.py#189jacob-prince merged 1 commit intomainfrom
jacob-prince merged 1 commit intomainfrom
Conversation
…handling in calcbadness.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two small bugs in GLMsingle Python implementation, described in #188:
Use cross-validated pcnum instead of total n_pc for PC selection
Fix session loop data copying in calcbadness function
session loop to preserve z-score transformations across sessions
losing transformations from earlier sessions
Both fixes ensure the algorithms use intended cross-validated parameters and preserve data transformations as designed. Fixes were validated with a test suite to ensure that the changes have the desired effect.