Fix pre vs. post-rewrite in proofs for theory preprocessor#6801
Merged
HanielB merged 6 commits intocvc5:masterfrom Jun 30, 2021
Merged
Fix pre vs. post-rewrite in proofs for theory preprocessor#6801HanielB merged 6 commits intocvc5:masterfrom
HanielB merged 6 commits intocvc5:masterfrom
Conversation
HanielB
reviewed
Jun 29, 2021
src/theory/theory_preprocessor.cpp
Outdated
Comment on lines
+313
to
+315
| // Finish the conversion by rewriting. Notice that we must consider this a | ||
| // pre-rewrite since we do not recursively register the rewriting steps | ||
| // of subterms of rtfNode. |
Member
There was a problem hiding this comment.
Could you say more about how this change solves the issue of not recursively registering the rewriting steps mentioned?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes an annotation of a step of rewriting from "post" to "pre" in the theory preprocessor.
Fixes #6754.