Skip to content

Fix re-elim length requirement for symbolic RE memberships#6609

Merged
4tXJ7f merged 5 commits intocvc5:masterfrom
ajreynol:reElimLenCons
May 24, 2021
Merged

Fix re-elim length requirement for symbolic RE memberships#6609
4tXJ7f merged 5 commits intocvc5:masterfrom
ajreynol:reElimLenCons

Conversation

@ajreynol
Copy link
Copy Markdown
Member

@ajreynol ajreynol commented May 24, 2021

Fixes #6604.

Previously, re-elim was solution unsound for cases where the LHS and a component of the RHS were both empty. This ensures a length requirement is given for the LHS to ensure proper containment.

@ajreynol ajreynol added major Priority moderate Complexity labels May 24, 2021
@ajreynol ajreynol requested a review from 4tXJ7f May 24, 2021 14:36
Copy link
Copy Markdown
Member

@4tXJ7f 4tXJ7f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

@4tXJ7f 4tXJ7f enabled auto-merge (squash) May 24, 2021 16:04
@4tXJ7f 4tXJ7f merged commit 1516e3b into cvc5:master May 24, 2021
@ajreynol ajreynol deleted the reElimLenCons branch November 5, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major Priority moderate Complexity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(re-elim) solution unsoundness on string formula

2 participants