Readd ruff check for scripts, but allow print and missing docstring#316
Merged
sveinse merged 2 commits intocustom-components:masterfrom Aug 31, 2025
Merged
Conversation
sveinse
reviewed
Aug 31, 2025
.ruff.toml
Outdated
Comment on lines
+11
to
+14
| "scripts/*" = [ | ||
| "D103", # Don't complain over missing docstrings in scripts | ||
| "T201", # Allow for scripts to write to stdout | ||
| ] |
Collaborator
There was a problem hiding this comment.
I regret placing the [lint.per-file-ignores] above the general [lint] section. Would you be so kind to move this entire section to below ´[lint]` please? I think it's best to have the main rules first in the files.
Contributor
Author
There was a problem hiding this comment.
I ended up reordering the sections to match the order in https://github.com/home-assistant/core/blob/dev/pyproject.toml.
I also added the pydocstyle section from HA-pyproject, which apparently disables the D401 First line of docstring should be in imperative mood-ruff-error (which I think we have discussed ignoring before at some point)
Also adds the pydocstyle and pytest-style-mark-parentheses = false (both from HA)
sveinse
approved these changes
Aug 31, 2025
Collaborator
sveinse
left a comment
There was a problem hiding this comment.
I think this looks good. Are we ready to merge?
Contributor
Author
|
Yep 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.