Skip to content

Add Version + Release action#11

Merged
ludeeus merged 5 commits intocustom-components:masterfrom
edenhaus:version
May 31, 2021
Merged

Add Version + Release action#11
ludeeus merged 5 commits intocustom-components:masterfrom
edenhaus:version

Conversation

@edenhaus
Copy link
Copy Markdown
Contributor

@edenhaus edenhaus commented May 6, 2021

Adds release action and version field, which is required for HA 2021.6+

@edenhaus
Copy link
Copy Markdown
Contributor Author

@ludeeus Can you please review this PR or delegate it to the correct person?

@brianhanifin
Copy link
Copy Markdown

This looks to make this compatible with Home Assistant 2021.06? Am I right?

@edenhaus
Copy link
Copy Markdown
Contributor Author

This looks to make this compatible with Home Assistant 2021.06? Am I right?

Yes exactly

@ludeeus
Copy link
Copy Markdown
Collaborator

ludeeus commented May 31, 2021

Someone with enough rights please add secrets.GITHUB_TOKEN

This is not something you can add, that is a default special secret that GitHub injects to the action during runtime 👍

Co-authored-by: Joakim Sørensen <hi@ludeeus.dev>
@edenhaus edenhaus requested a review from ludeeus May 31, 2021 09:29
@edenhaus
Copy link
Copy Markdown
Contributor Author

Someone with enough rights please add secrets.GITHUB_TOKEN

This is not something you can add, that is a default special secret that GitHub injects to the action during runtime +1

Thanks for clarification :)
I have committed your suggestions

Copy link
Copy Markdown
Collaborator

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 🎉

@ludeeus ludeeus merged commit bd80605 into custom-components:master May 31, 2021
@edenhaus edenhaus deleted the version branch May 31, 2021 09:54
Copy link
Copy Markdown

@brianhanifin brianhanifin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release looks to have resolved the no 'version' key warning in the Home Assistant 2021.05.x log. This is resolved!

DOMAIN = "readme"
DOMAIN_DATA = f"{DOMAIN}_data"
VERSION = "0.2.1"
INTEGRATION_VERSION = "0.0.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be changed to "0.2.2" for the Release action to work?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does the 0.0.0 get replaced when a new Release is tagged?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's replaced here and in the manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants