CMake // Fixed issue with static build for MSVC2010#74
Closed
snikulov wants to merge 1 commit intocurl:masterfrom
snikulov:cmake_vc2010_static_update
Closed
CMake // Fixed issue with static build for MSVC2010#74snikulov wants to merge 1 commit intocurl:masterfrom snikulov:cmake_vc2010_static_update
snikulov wants to merge 1 commit intocurl:masterfrom
snikulov:cmake_vc2010_static_update
Conversation
Member
|
On Tue, 9 Jul 2013, Sergei Nikulov wrote: Please send patches to the curl-library mailing list so that all interested / daniel.haxx.se |
Contributor
Author
|
I already done this http://curl.haxx.se/mail/lib-2013-07/0070.html |
Member
|
Thanks, merged and pushed with an edited commit message with details from here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue with static build for MSVC2010.
The issue was raised in following thread http://curl.haxx.se/mail/lib-2013-07/0046.html
After some investigation I've discovered known issue http://public.kitware.com/Bug/view.php?id=11240
When .rc file is linked to static lib it fails with following linker error
LINK : warning LNK4068: /MACHINE not specified; defaulting to X86
file.obj : fatal error LNK1112: module machine type 'x64' conflicts with target machine type 'X86'
Fix add target property /MACHINE: for MSVC generation.
Also removed old workarounds - it caused errors during msvc build.