Skip to content

http: move request-specific header storage to Curl_easy from connectdata#5567

Closed
bagder wants to merge 1 commit into
masterfrom
bagder/http-data-to-curl-easy
Closed

http: move request-specific header storage to Curl_easy from connectdata#5567
bagder wants to merge 1 commit into
masterfrom
bagder/http-data-to-curl-easy

Conversation

@bagder

@bagder bagder commented Jun 15, 2020

Copy link
Copy Markdown
Member

Since the connection can be used by many independent requests (using
HTTP/2 or HTTP/3), things like user-agent and other transfer-specific
data MUST NOT be kept connection oriented as it could lead to requests
getting the wrong string for their requests. This struct data was
lingering like this due to old HTTP1 legacy thinking where it didn't
mattered..

Fixes #5566

Since the connection can be used by many independent requests (using
HTTP/2 or HTTP/3), things like user-agent and other transfer-specific
data MUST NOT be kept connection oriented as it could lead to requests
getting the wrong string for their requests. This struct data was
lingering like this due to old HTTP1 legacy thinking where it didn't
mattered..

Fixes #5566
@bagder bagder added the HTTP label Jun 15, 2020
@bagder bagder changed the title http: move request-specific header storage to urldata from connectdata http: move request-specific header storage to Curl_easy from connectdata Jun 15, 2020
@bagder bagder closed this in e15e513 Jun 15, 2020
@bagder bagder deleted the bagder/http-data-to-curl-easy branch June 15, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

HTTP header fields stored per connection causes problems

1 participant