Makefile: run the cd commands in a subshell#5073
Closed
konimex wants to merge 1 commit intocurl:masterfrom
konimex:bmake
Closed
Makefile: run the cd commands in a subshell#5073konimex wants to merge 1 commit intocurl:masterfrom konimex:bmake
konimex wants to merge 1 commit intocurl:masterfrom
konimex:bmake
Conversation
In bmake, if the directory is changed (with cd or anything else), bmake won't return to the "root directory" on the next command (in the same Makefile rule). This commit runs the cd command in a subshell so it would work in bmake.
Member
|
Only one question: should we prefer |
Contributor
Author
|
If POSIX is of any concern, then the latter. However, both GNU make and BSD make support |
Member
|
Thanks! So let's go with the cd approach. Will merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In bmake, if the directory is changed (with cd or anything else), bmake won't return to the "root directory" on the next command (in the same Makefile rule). This commit runs the cd command in a subshell so it would work in bmake. This has been applied in
curl/Makefile.am
Line 726 in fb61344
Logs:
Before my commit
After my commit