openssl: make CURLINFO_CERTINFO not truncate x509v3 fields#4841
Closed
openssl: make CURLINFO_CERTINFO not truncate x509v3 fields#4841
Conversation
Avoid "reparsing" the content and instead deliver more exactly what is provided in the certificate and avoid truncating the data after 512 bytes as done previously. This no longer removes embedded newlines. Fixes #4837 Reported-by: bnfp on github
Contributor
|
After this change, I am not able to get the Subject Alternate Names (SAN) from certificate. |
Member
Author
|
Please submit an issue if you have an issue... |
Contributor
|
Leaving this comment just for information. This commit introduced a small change in the representation of the certinfo data. Prior to this commit, the "X509v3 Subject Alternative Name" data in the slist was stored as After this commit, the data is stored as Note the additional space after the comma in the new representation. |
Contributor
|
Thanks! I will change my consumer code to handle the extra space in SAN. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid "reparsing" the content and instead deliver more exactly what is
provided in the certificate and avoid truncating the data after 512
bytes as done previously. This no longer removes embedded newlines.
Fixes #4837
Reported-by: bnfp on github