Fix a bug that oauth_bearer is deallocated when we re-use a connection#4824
Closed
naost3rn wants to merge 5 commits intocurl:masterfrom
Closed
Fix a bug that oauth_bearer is deallocated when we re-use a connection#4824naost3rn wants to merge 5 commits intocurl:masterfrom
naost3rn wants to merge 5 commits intocurl:masterfrom
Conversation
Member
|
This made me think. Why do we store the 'bearer' in the connection anyway? Isn't the bearer rather per-transfer? I.e shouldn't it be moved from |
Member
|
The disable verbose build in travis failed: I presume you need to make 'data' available in that function unconditionally. |
get the bearer information from the old_conn struct since it may be new for this request even when we re-use an existing connection
…onnection" This reverts commit a5187f8163597be710ccf288c96cf6e904adc0c9.
remove oauth_bearer from struct connectdata and get the Bearer token from struct Curl_easy
bfc64eb to
ac3dbcb
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get the Bearer token from the old_conn struct since it may be new for this request even when we re-use an existing connection