Allow RCPT TO command to fail for some recipients#4816
Closed
volpav wants to merge 2 commits intocurl:masterfrom
Closed
Allow RCPT TO command to fail for some recipients#4816volpav wants to merge 2 commits intocurl:masterfrom
volpav wants to merge 2 commits intocurl:masterfrom
Conversation
Member
|
Please look into fixing your code for the CI errors. |
Member
|
Don't be alarmed by the red CI build(s), that's just due to flaky/bad environments and not because of any flaw in your PR. Ignore them. |
Member
|
It would be nice if you now could squash all your commits into a single one (and force-push that) to improve the review experience. |
bagder
reviewed
Jan 15, 2020
Contributor
Author
|
Folks, thanks for the early comments but this PR is not ready for review yet as I'm still dealing with the couple of things. Will send out for review once this is presentable. |
089704f to
f76cd1e
Compare
8ab7934 to
1c1b7b9
Compare
dc7f0b0 to
5450c70
Compare
Contributor
Author
|
Addressed initial feedback, made a couple minor changes. Some checks are still failing but I'm assuming it's due to the flakiness (as @bagder mentioned). New and existing tests for SMTP seem to be passing. |
bagder
approved these changes
Jan 20, 2020
…n the documentation.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #4792 adding a new option to control whether to allow
RCPT TOcommand to fail for some recipients (and proceed with the remaining valid ones).In case when all recipients cause failures, curl will abort SMTP conversation and return the error received from to the last
RCPT TOcommand.