bug: Let -D merge headers in one file again#4762
Closed
cvengler wants to merge 2 commits intocurl:masterfrom
cvengler:2019-12-dump-headers-append-fix
Closed
bug: Let -D merge headers in one file again#4762cvengler wants to merge 2 commits intocurl:masterfrom cvengler:2019-12-dump-headers-append-fix
cvengler wants to merge 2 commits intocurl:masterfrom
cvengler:2019-12-dump-headers-append-fix
Conversation
Member
|
Why do the tests need to be adjusted? Also, IIRC the way header file used to work was it was opened once, does something close it now? |
Contributor
Author
They were changed with b889408 |
Contributor
Author
Maybe |
Member
|
Contributor
Author
|
@bagder Will rebase it now and try to fix the tests |
Contributor
Author
|
The patch itself just got rebased. I will adjust the tests now |
Contributor
Author
|
I adjusted the tests with a695a36. They should pass now |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #4753
We check if this is the first run of the function, if so create a new file. The function is getting executed node by node of the linked list so we just check if it the first node by checking if the previous element is NULL.