ssh-libssh: fix infinite connect loop on invalid private key#2879
Closed
kdudka wants to merge 2 commits intocurl:masterfrom
Closed
ssh-libssh: fix infinite connect loop on invalid private key#2879kdudka wants to merge 2 commits intocurl:masterfrom
kdudka wants to merge 2 commits intocurl:masterfrom
Conversation
The verbose message "Authentication using SSH public key file" was printed each time the ssh_userauth_publickey_auto() was called, which meant each time a packet was transferred over network because the API operates in non-blocking mode. This patch makes sure that the verbose message is printed just once (when the authentication state is entered by the SSH state machine).
Added test 656 (based on test 604) to verify the fix. Bug: https://bugzilla.redhat.com/1595135
bagder
approved these changes
Aug 14, 2018
bagder
approved these changes
Aug 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test 656 (based on test 604) to verify the fix.
Bug: https://bugzilla.redhat.com/1595135