libcurl/Curl_resolv_timeout: curl_jmpenv should be set before alarm() call#28
Closed
ettoredn wants to merge 1 commit intocurl:masterfrom
ettoredn:master
Closed
libcurl/Curl_resolv_timeout: curl_jmpenv should be set before alarm() call#28ettoredn wants to merge 1 commit intocurl:masterfrom ettoredn:master
ettoredn wants to merge 1 commit intocurl:masterfrom
ettoredn:master
Conversation
Member
|
This patch got comments on the mailing list that was never followed-up or answered. This pull request is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
while debugging an issue in a PHP extension, i experienced some
segfaults caused by libcurl.
I found out the cause was at hostip.c:506:
siglongjmp(curl_jmpenv, 1);
curl_jmpenv was 0x0.
That happens when SIGALRM is sent before sigsetjmp is called at
hostip.c:609. This could happens, for example, while debugging or when
process is descheduled for a time greater than SIGALRM timeout.
This patch simply moves sigsetjmp() before alarm().