Skip to content

Fix curl compilation with mbedTLS 2.7.0 and above (compiled with MBED…#2453

Closed
wyattoday wants to merge 2 commits intocurl:masterfrom
wyattoday:master
Closed

Fix curl compilation with mbedTLS 2.7.0 and above (compiled with MBED…#2453
wyattoday wants to merge 2 commits intocurl:masterfrom
wyattoday:master

Conversation

@wyattoday
Copy link
Contributor

@wyattoday wyattoday commented Apr 3, 2018

…TLS_DEPRECATED_REMOVED), and add error code handling for failed sha256 computation.

Fixes issue #2442

@wyattoday
Fix curl compilation with mbedTLS 2.7.0 and above (compiled with MBED…
83ebbf8 
…TLS_DEPRECATED_REMOVED), and add error code handling for failed sha256 computation.
@bagder bagder added the TLS label Apr 5, 2018
@bagder
Copy link
Member

bagder commented Apr 5, 2018

Remember make checksrc to verify the code style somewhat:

./vtls/mbedtls.c:1036:5: warning: if with space (SPACEBEFOREPAREN)
   if (mbedtls_sha256_ret(input, inputlen, sha256sum, 0) != 0)
     ^
checksrc: 0 errors and 1 warnings
checksrc: 0 errors and 5 warnings suppressed

@wyattoday
Copy link
Contributor Author

wyattoday commented Apr 5, 2018

OK, just fixed the code style, ran the command again and came up all clean.

@bagder
Copy link
Member

bagder commented Apr 6, 2018

Thanks!

@bagder bagder closed this in 336b6a3 Apr 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

TLS

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wyattoday @bagder