build: make sure CFLAGS (including -werror) be used for examples and …#2337
Closed
build: make sure CFLAGS (including -werror) be used for examples and …#2337
Conversation
Member
Author
|
The #2335 problem is clearly visible now at least! |
…tests ... so that the CI and more detects compiler warnings/errors properly!
970ca2f to
d39b978
Compare
Member
|
I thought that was by design. I like this change, just note that it will need some fixup on MinGW. If I remember correctly, there's one warning in the examples because WinSock has non-standard signatures for send and recv and one warning in the tests about conversions between 32-bit long and 64-bit pointers. I'll try to have a look this afternoon. |
Member
Author
I'm sure that's not the only fixup we need! =) But I figure I should start with making sure the CI builds are all happy and then we can proceed just as usual and fix the problems when we fall over them... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tests
... so that the CI and more detects compiler warnings/errors properly!