ngtcp2: retune window sizes#20033
Closed
icing wants to merge 2 commits intocurl:masterfrom
Closed
Conversation
With 24b36fd stream flow control window sizes have been set too restrictive, crippling transfer rates when no rate limit is in effect. Disable ngtcp3 stream window auto-tuning and extend the stream window from the small initial size to the effective rate limit. If no rate limit is configured, extend stream window to maximum value right away. This cannot shrink the stream window later, however. But growing the limit or removing it, will work mid download. refs curl#20030
d5a741f to
045666c
Compare
bagder
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 24b36fd stream flow control window sizes have been set too restrictive, crippling transfer rates when no rate limit is in effect.
Disable ngtcp2 stream window auto-tuning and extend the stream window from the small initial size to the effective rate limit. If no rate limit is configured, extend stream window to maximum value right away.
This cannot shrink the stream window later, however. But growing the limit or removing it, will work mid download.
refs #20030