tests/server: fix initialization on Windows Vista+#19973
Closed
vszakats wants to merge 3 commits intocurl:masterfrom
Closed
tests/server: fix initialization on Windows Vista+#19973vszakats wants to merge 3 commits intocurl:masterfrom
vszakats wants to merge 3 commits intocurl:masterfrom
Conversation
Make sure to call `curlx_now_init()` before the first call to `curlx_now()`. Bug: curl#18009 (comment)
This reverts commit 77e97e2.
2 tasks
Member
Author
|
Confirmed fixing PR #18009 with Vista+-only code path: |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to call
curlx_now_init()before the first call tocurlx_now().Before this patch the first
curlx_now()used the non-Vista code pathcalling
GetTickCount()on Vista+. This is harmless, but the upcomingPR #18009 is going to drop the non-Vista code path, causing a division
by zero at startup in test servers, without this fix.
Bug: #18009 (comment)