doh: rename symbols to avoid collision with mingw-w64 headers#18041
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
doh: rename symbols to avoid collision with mingw-w64 headers#18041vszakats wants to merge 2 commits intocurl:masterfrom
vszakats wants to merge 2 commits intocurl:masterfrom
Conversation
It happens when building against mingw-w64 v3 or older while targeting Vista or newer. `iphlpapi.h` includes `windns.h` in this case, which defines macros named `DNS_TYPE_*`, colliding with curl doh enums. The issue was fixed in mingw-w64 v4: mirror/mingw-w64@ea95d55 Fixes: ``` lib/doh.h:54:3: error: expected identifier before numeric constant DNS_TYPE_A = 1, ^ ``` Ref: https://github.com/curl/curl/actions/runs/16551209676/job/46806303365?pr=18009#step:10:17 This workaround seems harmless and generally good practice, but another option is to require mingw-w64 v4.
13 tasks
bagder
approved these changes
Jul 27, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collision happens when building with mingw-w64 v3 or v2 while targeting
Vista or newer.
iphlpapi.hincludeswindns.hin this case, whichdefines macros named
DNS_TYPE_*, colliding with curl doh enums.The issue was fixed in mingw-w64 v4:
mirror/mingw-w64@ea95d55
Fixes:
Ref: https://github.com/curl/curl/actions/runs/16551209676/job/46806303365?pr=18009#step:10:17
This workaround seems harmless and generally good practice, but
another option is to require mingw-w64 v4.
Ref: #18009