cmake: use host OS to decide about libcurl manpage batch size#14733
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
cmake: use host OS to decide about libcurl manpage batch size#14733vszakats wants to merge 1 commit intocurl:masterfrom
vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
Before this patch the targe OS was used, which prevented building libcurl manpages in larger batches in cross-builds targeting e.g. Windows. Update the condition to use `CMAKE_HOST_UNIX` instead of `UNIX`. This variable has been available since CMake 2.6.0: Kitware/CMake@176fe63 Follow-up to bb84f82 curl#13207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch the targe OS was used, which prevented building
libcurl manpages in larger batches in cross-builds targeting e.g.
Windows.
Update the condition to use
CMAKE_HOST_UNIXinstead ofUNIX.This variable has been available since CMake 2.6.0:
Kitware/CMake@176fe63
Follow-up to bb84f82 #13207