dragonfly: change tcp keepalive options from ms to seconds#13848
Closed
panjf2000 wants to merge 2 commits intocurl:masterfrom
Closed
dragonfly: change tcp keepalive options from ms to seconds#13848panjf2000 wants to merge 2 commits intocurl:masterfrom
panjf2000 wants to merge 2 commits intocurl:masterfrom
Conversation
DragonFly BSD changed the time unit for TCP keep-alive from milliseconds to seconds since v5.8, thus setting the keepalive options with milliseconds with curl/libcurl will result in unexpected behaviors on DragonFlyBSD 5.8+ Distinguish the DragonFly BSD versions and use the proper time units accordingly. Ref: https://lists.dragonflybsd.org/pipermail/commits/2019-July/719125.html https://github.com/DragonFlyBSD/DragonFlyBSD/blob/965b380e960908836b97aa034fa2753091e0172e/sys/sys/param.h#L207 Fixes curl#13847
ef9f6a4 to
30e7329
Compare
Member
|
cf9057c to
07f982e
Compare
Contributor
Author
Fixed! |
bagder
approved these changes
Jun 1, 2024
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DragonFly BSD changed the time unit for TCP keep-alive from milliseconds to seconds since v5.8, thus setting the keepalive options with milliseconds with curl/libcurl will result in unexpected behaviors on DragonFlyBSD 5.8+
Distinguish the DragonFly BSD versions and use the proper time units accordingly.
Ref:
https://lists.dragonflybsd.org/pipermail/commits/2019-July/719125.html
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/965b380e960908836b97aa034fa2753091e0172e/sys/sys/param.h#L207
Fixes #13847