aws-sigv4: fix canonical path encoding#13814
Closed
outscale-mgo wants to merge 2 commits intocurl:masterfrom
Closed
aws-sigv4: fix canonical path encoding#13814outscale-mgo wants to merge 2 commits intocurl:masterfrom
outscale-mgo wants to merge 2 commits intocurl:masterfrom
Conversation
923c78f to
5c31b6c
Compare
5c31b6c to
b03a0b0
Compare
bagder
reviewed
May 28, 2024
I refactor canon_query, so I could use the encoding part of the function to use it in the path. As the path doesn't encode '/', but encode '=', I had to add some conditions to know If I was doing the query or path encoding. Also, instead of adding a `bool in_path` variable, I use `bool *found_equals` to know if the function was called for the query or path, as found_equals is used only in query_encoding. fix: curl#13754 Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
b03a0b0 to
bdc5d13
Compare
bagder
approved these changes
May 29, 2024
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #13754
I refactor canon_query, so I could use the encoding part of the function to use it in the path.
As the path doesn't encode '/', but encode '=', I had to add some conditions to know If I was doing the query or path encoding.
Also, instead of adding a
bool in_pathvariable, I usebool *found_equalsto know if the function was called for the query or path, as found_equals is used only in query_encoding.Note: When I try replacing manually
=with%3D, curl without this patch worked, so they might still be a bug out-there.