NTLM: check for features with #ifdef instead of #if#1367
Closed
MarcelRaad wants to merge 1 commit intocurl:masterfrom
Closed
NTLM: check for features with #ifdef instead of #if#1367MarcelRaad wants to merge 1 commit intocurl:masterfrom
MarcelRaad wants to merge 1 commit intocurl:masterfrom
Conversation
Feature defines are normally checked with #ifdef instead of #if in the rest of the codebase. Additionally, some compilers warn when a macro is implicitly evaluated to 0 because it is not defined, which was the case here. Ref: curl#1362 (comment)
|
@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @yangtse and @bagder to be potential reviewers. |
bagder
approved these changes
Mar 29, 2017
jay
approved these changes
Mar 29, 2017
Member
jay
left a comment
There was a problem hiding this comment.
Looks good, before sending this upstream please amend the commit message with a Ref: or Closes line with this PR#
Member
Author
|
Thanks for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature defines are normally checked with #ifdef instead of #if in the rest of
the codebase. Additionally, some compilers warn when a macro is implicitly
evaluated to 0 because it is not defined, which was the case here.
Ref: #1362 (comment)