examples/websocket.c: check for CURLE_AGAIN on recv_pong()#12980
Closed
Theldus wants to merge 4 commits intocurl:masterfrom
Closed
examples/websocket.c: check for CURLE_AGAIN on recv_pong()#12980Theldus wants to merge 4 commits intocurl:masterfrom
Theldus wants to merge 4 commits intocurl:masterfrom
Conversation
vszakats
reviewed
Jun 3, 2024
The example file docs/examples/websocket.c does not work out of the box, because the recv_pong() function does not consider that the curl_ws_recv() function might return CURLE_AGAIN if there is no data to read, causing the program to terminate prematurely. This commit addresses this by using select(2) to make receiving pong blocking, and thus being able to continue with the main loop. This also occurs in the example file sendrecv.c, which also makes use of select(2) for sending and receiving data, which I based on for this commit.
244759d to
e8d0cd0
Compare
vszakats
reviewed
Jan 28, 2025
Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
vszakats
reviewed
Mar 26, 2025
vszakats
reviewed
Mar 26, 2025
Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
Member
|
websocket example's ping received retries and waits in fa0ed1f #17860, Closing this in favor of the above. In any case if you'd like continue this effort, please rebase it, or create a new PR from the fresh source. diff without whitespace changes: https://github.com/curl/curl/pull/12980/files?w=1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The example file docs/examples/websocket.c does not work out of the box, because the recv_pong() function does not consider that the
curl_ws_recv()function might return CURLE_AGAIN if there is no data to read, causing the program to terminate prematurely.This commit addresses this by using
select(2)to make receiving pong blocking, and thus being able to continue with the main loop.This also occurs in the example file sendrecv.c, which also makes use of select(2) for sending and receiving data, which I based on for this commit.