I suppose this is a bug with the curl/curl repo participating in hacktoberfest? Anyway...

I did this

I'm not sure when the hacktoberfest topic was added to the repository, but when a recent PR got approved by a maintainer I received an email from Hacktoberfest saying a PR had been completed in the curl/curl repository. When the PR was closed by the manually merged commit method used here (i.e. PR shows with the red closed status icon rather than purple merged status icon), that overrides the approving review and the PR goes back to not counting towards hacktoberfest.

I expected the following

I mentioned this to the folks running hacktoberfest as not following the valid PR logic they tell people, and the reasoning they gave for it working this way is that they think a PR with an approving review that has a closed status is more likely to mean that the project decided against making the change (and they don't have an easy way to track PRs that have been closed by a commit like this).

The suggested alternative by them for if the curl project wants to participate in hacktoberfest is labelling individual PRs with the hacktoberfest-accepted label, which in a test I did to confirm does appear to ignore the closed/merged status of PRs.

curl/libcurl version

N/A

operating system

N/A