fix: ensure ALLOWED_URI_REGEXP is reset#790
Merged
cure53 merged 1 commit intocure53:mainfrom Apr 13, 2023
Merged
Conversation
At 490c2ef, the `ALLOWED_URI_REGEXP` was set without properly resetting it for subsequent sanitize calls.
Owner
|
Oh, nice find, thanks! |
Contributor
Author
|
Thanks for the quick merge, @cure53 ! Do you happen to have a release date for this change ? |
Owner
|
Soon. Once I am back from vaycay 😸 |
Owner
|
Release is out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The value of
ALLOWED_URI_REGEXPis persisted between santize calls without being properly reset.This pull request fixes it by resetting
IS_ALLOWED_URIto its default value instead of its previous value ifALLOWED_URI_REGEXPis not sentBackground & Context
At 490c2ef, the
IS_ALLOWED_URIwas set without properly resetting it for subsequent sanitize calls.