Skip to content

Test CUB SpMV#3428

Merged
mergify[bot] merged 1 commit intocupy:masterfrom
leofang:test_cub_spmv
Jun 18, 2020
Merged

Test CUB SpMV#3428
mergify[bot] merged 1 commit intocupy:masterfrom
leofang:test_cub_spmv

Conversation

@leofang
Copy link
Copy Markdown
Member

@leofang leofang commented Jun 11, 2020 •
edited
Loading

This tests against the CUB SpMV support added in #2698. Style in line with the existing tests and #2598. Not sure why I didn't add this in #2598...

@grlee77 Could you take a look?

@leofang
Test CUB spmv
17f2f46 
style in line with the existing tests and cupy#2598
This was referenced Jun 11, 2020
Merged
Merged
@leofang leofang changed the title Test CUB spmv Test CUB SpMV Jun 11, 2020
@kmaehashi kmaehashi added this to the v8.0.0b4 milestone Jun 12, 2020
@emcastillo
Copy link
Copy Markdown
Member

emcastillo commented Jun 18, 2020

Jenkins, test this please

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

pfn-ci-bot commented Jun 18, 2020

Successfully created a job for commit 17f2f46:

@emcastillo emcastillo added the cat:test Test code / CI label Jun 18, 2020
@emcastillo
Copy link
Copy Markdown
Member

emcastillo commented Jun 18, 2020

The test actually doesn't ensure that cub is being used for the spmv, but I don't think there is an easy way to do that, so LGTM

@emcastillo emcastillo added the st:test-and-merge (deprecated) Ready to merge after test pass. label Jun 18, 2020
@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Jun 18, 2020

Jenkins CI test (for commit 17f2f46, target branch master) succeeded!

@mergify mergify bot merged commit e1d3ff1 into cupy:master Jun 18, 2020
@leofang leofang deleted the test_cub_spmv branch June 18, 2020 11:23
@leofang
Copy link
Copy Markdown
Member Author

leofang commented Jun 18, 2020

The test actually doesn't ensure that cub is being used for the spmv

Thanks, @emcastillo!

That's right, but I think it's the same for all existing CUB tests...That's why in the beginning of #2598 I suggested to monitor the performance change (under the assumption that CUB is always faster). Not sure whether the backend mechanism suggested in #3445 could help for this purpose?

@leofang
Copy link
Copy Markdown
Member Author

leofang commented Jun 20, 2020

The test actually doesn't ensure that cub is being used for the spmv

Sorry @emcastillo, I was being silly. Mock tests are exactly for this purpose! I will write mock tests to cover the whole cupy.cuda.cub module.

This was referenced Jun 20, 2020
Merged
Merged
@leofang leofang mentioned this pull request Jul 2, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@emcastillo emcastillo emcastillo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@emcastillo emcastillo

Labels

cat:test Test code / CI st:test-and-merge (deprecated) Ready to merge after test pass.

Projects

None yet

Milestone

v8.0.0b4

Development

Successfully merging this pull request may close these issues.

5 participants

@leofang @emcastillo @pfn-ci-bot @chainer-ci @kmaehashi