Remove unnecessary Arg instantiation in cuda/function.pyx#3253
Merged
mergify[bot] merged 1 commit intocupy:masterfrom Apr 6, 2020
Merged
Remove unnecessary Arg instantiation in cuda/function.pyx#3253mergify[bot] merged 1 commit intocupy:masterfrom
Arg instantiation in cuda/function.pyx#3253mergify[bot] merged 1 commit intocupy:masterfrom
Conversation
7 tasks
leofang
reviewed
Apr 2, 2020
Comment on lines
92
to
93
| if isinstance(x, core.ndarray): | ||
| return (<core.ndarray>x).get_pointer() |
Member
There was a problem hiding this comment.
Dumb question (still trying to figure out what happened with the new Arg 😅): Isn't there a NdarrayArg? Why not also removing these two lines?
Member
Author
There was a problem hiding this comment.
This function is called only from here now and NdarrayArg does not reach here.
All indexers and scalars are converted to IndexerArg and ScalarArg, so these lines can be removed.
Member
There was a problem hiding this comment.
I see, thanks @asi1024. I am still fuzzy about when exactly NdarrayArg is needed, though...A few pointers from you are greatly appreciated!
Member
|
Jenkins, test this please |
Collaborator
|
Successfully created a job for commit 3d85810: |
Member
|
Jenkins CI test (for commit 3d85810, target branch master) succeeded! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves performance degradation in
function.pyx.note: #2920 (review)
v8.0.01bmasterf2bee1b)