Merged
Conversation
Member
Author
|
You might as well review #2918 altogether as it's based on this PR. |
toslunar
approved these changes
Jan 8, 2020
| cdef CScalar from_int32(int32_t value) | ||
|
|
||
| @staticmethod | ||
| cdef CScalar from_numpy_scalar_with_dtype(object x, object dtype) |
Member
There was a problem hiding this comment.
Note:
These methods are still considered as private because the class CScalar is in a private module and Cython "cannot call a static method on an instance variable".
https://github.com/cython/cython/blob/3dc2b9dfc23638fbef2558d619709b5235d5df08/Cython/Compiler/ExprNodes.py#L5619-L5624
Member
|
Jenkins, test this please. |
Collaborator
|
Successfully created a job for commit 0b6113b: |
Member
|
Jenkins CI test (for commit 0b6113b, target branch master) succeeded! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up
_scalar.pyx/pxd.convert_scalar()returned different types of objects depending on a flag. This is confusing because the return type is obscure.CScalar's various creation functions into static methodsCScalar.from_xxx().