Skip to content

Support thrust with ROCm#2666

Merged
emcastillo merged 3 commits intocupy:masterfrom
okuta:hipthrust
Nov 22, 2019
Merged

Support thrust with ROCm#2666
emcastillo merged 3 commits intocupy:masterfrom
okuta:hipthrust

Conversation

@okuta
Copy link
Copy Markdown
Member

@okuta okuta commented Nov 21, 2019

rel #1117

@okuta okuta mentioned this pull request Nov 21, 2019
11 tasks
@leofang
Copy link
Copy Markdown
Member

leofang commented Nov 21, 2019

@okuta Glad to see this support added! With Thrust + ROCm in mind, do you have any comment for #2629? I wonder if it’s possible to remove CuPy’s copy of Thrust headers completely?

Copy link
Copy Markdown
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emcastillo
Copy link
Copy Markdown
Member

Jenkins, test this please

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit 593594e:

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit 593594e, target branch master) succeeded!

@emcastillo emcastillo merged commit 2e05154 into cupy:master Nov 22, 2019
@okuta okuta deleted the hipthrust branch December 2, 2019 17:17
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
@kmaehashi kmaehashi added the cat:enhancement Improvements to existing features label Dec 5, 2019
@leofang leofang mentioned this pull request Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:enhancement Improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants