Skip to content

Introduce errstate and related functions#2535

Merged
asi1024 merged 3 commits intocupy:masterfrom
hvy:errstate
Nov 1, 2019
Merged

Introduce errstate and related functions#2535
asi1024 merged 3 commits intocupy:masterfrom
hvy:errstate

Conversation

@hvy
Copy link
Copy Markdown
Member

@hvy hvy commented Oct 8, 2019

Partially fixes #2436.

TODO

TODO in later PR

  • Consider implement/support NumPy compatible options, divide, etc.

@hvy hvy added the cat:feature New features/APIs label Oct 8, 2019
@asi1024 asi1024 self-assigned this Oct 8, 2019
@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Oct 31, 2019

@hvy LGTM other than the filename. I feel _ufunc_config.py is better.

@hvy hvy changed the title [WIP] Introduce errstate and related functions Introduce errstate and related functions Oct 31, 2019
@hvy hvy marked this pull request as ready for review October 31, 2019 09:25
@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Oct 31, 2019

Jenkins, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit b53b2b9:

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit b53b2b9, target branch master) succeeded!

@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Nov 1, 2019

LGTM.

@asi1024 asi1024 merged commit b52bedd into cupy:master Nov 1, 2019
@asi1024 asi1024 added this to the v7.0.0 milestone Nov 1, 2019
@hvy hvy deleted the errstate branch November 1, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:feature New features/APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC] Introduce a configuration mechanism

4 participants